Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add geospatial type support #349

Merged
merged 14 commits into from
Apr 19, 2022
Merged

add geospatial type support #349

merged 14 commits into from
Apr 19, 2022

Conversation

Jaysok
Copy link
Contributor

@Jaysok Jaysok commented Apr 19, 2022

Description

This will add geospatial type support. Thus resolves #341

External Dependency

Added external dependency from @types/geojson which already defined geojson types pretty good, conforming rfc7946 - GeoJSON Format.

Tests

I focused mainly on making a geospatial query easily and make simple GeoJSON queries work with newly added types.
Test data is mostly from MongoDB official documents and I picked some from there.
GeoJSON query objects in the actual queries are picked from the data or made by myself.

Possible issues in the future

  • Aggregation operator $geoNear is not considered.
  • MongoDB versioning is not strictly considered.

@Jaysok Jaysok requested a review from erfanium as a code owner April 19, 2022 06:25
@lucsoft
Copy link
Collaborator

lucsoft commented Apr 19, 2022

Could you rebase aka fix the merge conflicts from master

@Jaysok
Copy link
Contributor Author

Jaysok commented Apr 19, 2022

Could you rebase aka fix the merge conflicts from master

OK, I've just done it

deps.ts Outdated Show resolved Hide resolved
@erfanium erfanium merged commit 5539f8d into denodrivers:main Apr 19, 2022
@erfanium
Copy link
Member

@Jaysok Great, thank you!

@Jaysok
Copy link
Contributor Author

Jaysok commented Apr 19, 2022

@Jaysok Great, thank you!

Thank you either! @erfanium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use GeoJSON point as the value of $nearSphere operator
3 participants